fix hide options route by default (#142)

fastify · Jul 14, 2021 · 2b84669 · 2b84669
1 parent ca5e606
commit 2b84669
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/index.js b/index.js
@@ -23,7 +23,7 @@ function fastifyCors (fastify, opts, next) {
   if (typeof opts === 'function') {
     handleCorsOptionsDelegator(opts, fastify)
   } else {
-    hideOptionsRoute = opts.hideOptionsRoute
+    if (opts.hideOptionsRoute !== undefined) hideOptionsRoute = opts.hideOptionsRoute
     const corsOptions = Object.assign({}, defaultOptions, opts)
     fastify.addHook('onRequest', (req, reply, next) => {
       onRequest(fastify, corsOptions, req, reply, next)

diff --git a/test/preflight.test.js b/test/preflight.test.js
@@ -183,6 +183,23 @@ test('Should support a prefix for preflight requests', t => {
   })
 })
 
+test('hide options route by default', t => {
+  t.plan(2)
+
+  const fastify = Fastify()
+
+  fastify.addHook('onRoute', (route) => {
+    if (route.method === 'OPTIONS' && route.url === '*') {
+      t.equal(route.schema.hide, true)
+    }
+  })
+  fastify.register(cors)
+
+  fastify.ready(err => {
+    t.error(err)
+  })
+})
+
 test('show options route', t => {
   t.plan(2)