Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing parameter for type of build function in fastify-cli/helper #724

Merged
merged 2 commits into from
Jun 12, 2024
Merged

Conversation

zetaraku
Copy link
Contributor

@zetaraku zetaraku commented May 20, 2024

The third parameter of build is missing in the type declaration file, preventing users from passing the third parameter.

Image

This PR also renames the parameters in the doc to align with the parameter names in helper.js.

Checklist

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Member

CI is failing

@zetaraku
Copy link
Contributor Author

Fixed the problem and ran the test successfully :)

@mcollina mcollina merged commit 05cf81a into fastify:master Jun 12, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants