Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove build:ts step from npm start Task #707

Closed
wants to merge 1 commit into from

Conversation

zoulou00
Copy link

[

Checklist

@mcollina
Copy link
Member

Why?

@zoulou00
Copy link
Author

zoulou00 commented Feb 16, 2024

To resolve the issue #705
I thought this is what you wanted to do... sorry if it's not the case

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the context.
I think we should have:

  1. npm start that starts the server for production
  2. npm start:dev that calls npm run build:ts and npm start

@bishopandco
Copy link

I stumbled on this PR because I am doing DevOps for a fastify app (that I didn't write) and was looking for recommendations for running fastify in supervisor.conf.

@jean-michelet
Copy link
Contributor

I think this PR can be closed now:

'dev:start': 'fastify start --ignore-watch=.ts$ -w -l info -P dist/app.js'

@zoulou00 zoulou00 closed this Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants