Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: use node: prefix to bypass require.cache call for builtins #658

Merged
merged 2 commits into from
Oct 30, 2023
Merged

perf: use node: prefix to bypass require.cache call for builtins #658

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3073723
perf: use `node:` prefix to bypass require.cache call for builtins
Fdawgs Sep 10, 2023
55ffdae
test(start): fix mock
Fdawgs Oct 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test(start): fix mock
  • Loading branch information
@Fdawgs
Fdawgs committed Oct 28, 2023
commit 55ffdae74930232a6d2a83602263945bcbacbe0a
4 changes: 2 additions & 2 deletions test/start.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -714,7 +714,7 @@ test('should start the server with inspect options and the defalut port is 9320'
t.plan(3)

const start = proxyquire('../start', {
inspector: {
'node:inspector': {
open (p) {
t.equal(p, 9320)
t.pass('inspect open called')
Expand All @@ -733,7 +733,7 @@ test('should start the server with inspect options and use the exactly port', as

const port = getPort()
const start = proxyquire('../start', {
inspector: {
'node:inspector': {
open (p) {
t.equal(p, Number(port))
t.pass('inspect open called')
Expand Down
Loading