Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prefix. Refactor to run multiple tests #12

Merged
merged 3 commits into from
Sep 22, 2017

Conversation

allevo
Copy link
Member

@allevo allevo commented Sep 21, 2017

Refactorize in order to return fastify instance. So the test can start and stop the instance and run multiple tests.

Add prefix command line parameter

@mcollina
Copy link
Member

The tests are failing on travis.

@allevo
Copy link
Member Author

allevo commented Sep 21, 2017

@mcollina sorry my bad, old fastify version that not supports prefix option

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit b8914d6 into fastify:master Sep 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants