refactor(index): remove redundant regex non-capture group#179
Merged
Conversation
Signed-off-by: Frazer Smith <frazer.dev@icloud.com>
There was a problem hiding this comment.
Pull request overview
This PR simplifies a regex pattern by removing an unnecessary non-capturing group around the literal string "basic". The change refactors (?:basic) to just basic in the authScheme constant, which is then interpolated into larger regex patterns for HTTP Basic authentication credential validation.
- Removed redundant non-capturing group syntax from the
authSchemeconstant
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Member
|
I know these are chores, but please wait for an approve before merging 🙏🏼 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm run test && npm run benchmark --if-presentand the Code of conduct