Skip to content

Comments

refactor(index): enforce strict regex#178

Merged
Fdawgs merged 1 commit intomainfrom
refactor/index-regex
Nov 28, 2025
Merged

refactor(index): enforce strict regex#178
Fdawgs merged 1 commit intomainfrom
refactor/index-regex

Conversation

@Fdawgs
Copy link
Member

@Fdawgs Fdawgs commented Nov 28, 2025

u unicode flag is equivalent to 'use strict' directive in JS

Checklist

`u` unicode flag is equivalent to `'use strict'` directive in JS

Signed-off-by: Frazer Smith <frazer.dev@icloud.com>
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds the u (unicode) flag to four regular expression patterns in the Basic Auth plugin to enforce stricter and more predictable regex behavior.

Key changes:

  • Added u flag to credentialsStrictRE and credentialsLaxRE (combining with existing i flag)
  • Added u flag to controlRE and userPassRE patterns

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@Fdawgs Fdawgs merged commit af85b7b into main Nov 28, 2025
23 checks passed
@Fdawgs Fdawgs deleted the refactor/index-regex branch November 28, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant