This repository was archived by the owner on Feb 2, 2024. It is now read-only.
issue: #33 - Should support undici timeout err.code #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update upstream master
Contributor
|
LGTM +1 |
mcollina
reviewed
Jul 13, 2020
package.json
Outdated
| { | ||
| "name": "fast-proxy", | ||
| "version": "1.6.3", | ||
| "version": "1.6.4", |
Member
There was a problem hiding this comment.
I prefer we bump this during release.
test/5.undici.test.js
Outdated
| const bodyParser = require('body-parser') | ||
| const expect = require('chai').expect | ||
|
|
||
| const sleep = (milliseconds) => new Promise((resolve) => setTimeout(resolve, milliseconds)) |
Member
There was a problem hiding this comment.
I would use promisify(setTimeout) instead.
test/5.undici.test.js
Outdated
| res.send() | ||
| }) | ||
| service.get('/service/timeout', async (req, res) => { | ||
| await sleep(2000) |
Member
There was a problem hiding this comment.
why do we need 2 seconds of wait? I would prefer not to increase the slow down the testing.
Contributor
There was a problem hiding this comment.
resolved - reduced to 200ms
1. use promisify for sleep function 2. reduce sleep time from 2 sec to 200 ms
1. use promisify for sleep function 2. reduce sleep time from 2 sec to 200 ms 3. removed test timeout
Contributor
Author
|
hi @jkyberneees , |
Contributor
|
Hi @yohayg sorry for the delay on this, crazy busy on my side. Could you please resolve the conflicts here so I can merge and release both commits. |
…-timeout # Conflicts: # test/5.undici.test.js
Contributor
Author
|
@jkyberneees - conflicts are resolved |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm run testandnpm run benchmark