Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use more strict type for schema #134

Merged
merged 2 commits into from
Sep 28, 2022
Merged

Use more strict type for schema #134

merged 2 commits into from
Sep 28, 2022

Conversation

klaseca
Copy link
Contributor

@klaseca klaseca commented Sep 25, 2022

Checklist

climba03003
climba03003 requested changes Sep 25, 2022
View reviewed changes
Copy link
Member

@climba03003 climba03003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This library should accept any JSON Schema library.
For example typebox.

Can you add an integration test for 3rd party library?

mcollina
mcollina approved these changes Sep 27, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 3307ab4 into fastify:master Sep 28, 2022
@SleepWalker
Copy link

You'll get TS errors after this PR if your project doesn't depend from all the schema libs used for typings:

image

@klaseca klaseca mentioned this pull request Nov 10, 2022
Merged
4 tasks
@klaseca klaseca mentioned this pull request Feb 7, 2023
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@climba03003 climba03003 climba03003 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@klaseca @SleepWalker @mcollina @climba03003