chore: remove unnecessary arguments #122
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes unnecessary arguments and improves test coverage.
In #40, a workaround is added to avoid the undefined error.
It says "In some cases" but it is actually "In all cases" because the arguments are changed in v7.
Ref: ajv-validator/ajv@9e2e6b9#diff-489d67aa91e09063da5c34330526703a13b3cdedf7d86426173d0bc62183b6c7L36-L50
Now there are 2 arguments
data
anddataCxt
.Ref: https://github.com/ajv-validator/ajv/blob/master/lib/types/index.ts#L50-L57
Ref2: https://github.com/ajv-validator/ajv/blob/master/lib/vocabularies/code.ts#L75-L91
Therefore, I guess we can remove the if statement.
Checklist
npm run test
andnpm run benchmark
and the Code of conduct