Refactor/leverage getdecorator api#102
Closed
jean-michelet wants to merge 21 commits intofastify:mainfrom
Closed
Conversation
|
Member
Author
|
Started from an existing branch before pulling, which caused this commit history mess. |
Member
Author
|
I need several feedback on the style, this is why I ask for 3 reviews. |
jean-michelet
commented
Apr 15, 2025
| function verifyAccess (this: FastifyRequest, reply: FastifyReply, role: string) { | ||
| if (!this.session.user.roles.includes(role)) { | ||
| reply.status(403).send('You are not authorized to access this resource.') | ||
| function createChecker () { |
Member
Author
There was a problem hiding this comment.
Suggested change
| function createChecker () { | |
| function createManager () { |
| // you should decorate the request. | ||
| // This reduces coupling with the authentication strategy. | ||
| // If you change or add new authentication strategies in the future, | ||
| // `request.auth` remains the single source of truth. |
Member
Author
There was a problem hiding this comment.
Suggested change
| // `request.auth` remains the single source of truth. | |
| // `request[kAuth]` remains the single source of truth. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement #99
This change uses the new
getDecoratorAPI to reduce module augmentation and improve both type safety and runtime safety.Reference: https://fastify.dev/docs/latest/Reference/Decorators/#getdecoratort-api
There are other ways to ensure runtime safety with decorators, but using TypeScript, this approach it easier as perform static and runtime checks in one place.
I used Symbol to name decorators, don't know what you think about that.