Skip to content

Comments

Test: from tap to node runner#247

Merged
adrai merged 11 commits intofastify:masterfrom
SamSalvatico:test/from-tap-to-node
Jan 22, 2025
Merged

Test: from tap to node runner#247
adrai merged 11 commits intofastify:masterfrom
SamSalvatico:test/from-tap-to-node

Conversation

@SamSalvatico
Copy link
Contributor

Checklist

Moving the tests from tap to the node test runner, based on what requested in the following issue
Fastify #5555

@adrai
Copy link
Member

adrai commented Jan 21, 2025

can you rebase with master please?

adrai and others added 3 commits January 22, 2025 08:28
Signed-off-by: SamSalvatico <40636569+SamSalvatico@users.noreply.github.com>
@SamSalvatico
Copy link
Contributor Author

can you rebase with master please?

Done!

@SamSalvatico
Copy link
Contributor Author

@adrai I already had this problem when updating the tests on fastify-autoload
It is because windows doesn't manage the expansion of patterns automatically
We have two ways to fix this:

  • as I did for autoload, using fast-glob
  • specify all the files that needs to be tested in the script, without using patterns

@adrai
Copy link
Member

adrai commented Jan 22, 2025

let's use fast-glob

@adrai adrai merged commit 26797ae into fastify:master Jan 22, 2025
11 checks passed
@adrai
Copy link
Member

adrai commented Jan 22, 2025

thank you for your contribution

@SamSalvatico SamSalvatico deleted the test/from-tap-to-node branch January 22, 2025 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants