Skip to content

Fix build error on Windows #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix build error on Windows #80

wants to merge 2 commits into from

Conversation

@ysc3839
Copy link

@ysc3839 ysc3839 commented Jun 6, 2021

No description provided.

@ysc3839 ysc3839 mentioned this pull request Jun 6, 2021
Merged
@ysc3839 ysc3839 changed the title Fix MSVC ARM32 detection. Fix build error on Windows Jun 6, 2021
@lemire
Copy link
Member

lemire commented Jun 6, 2021

64-bit ARM under Windows has the __umulh intrinsic, there is no need to emulate it.

I think that defined(_M_ARM) will detect both 64-bit and 32-bit ARM. We only want to detect 32-bit ARM.

Can you narrow down your patch to 32-bit ARM specifically?

@lemire
Copy link
Member

lemire commented Jun 7, 2021

Fixed with tests at #81

@lemire lemire closed this Jun 7, 2021
@ysc3839 ysc3839 deleted the windows-arm branch June 7, 2021 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ysc3839 @lemire