Skip to content

Conversation

@CarterLi
Copy link
Member

@CarterLi CarterLi commented Sep 25, 2022

image

@CarterLi CarterLi closed this Sep 25, 2022
@CarterLi CarterLi reopened this Sep 25, 2022
@CarterLi CarterLi changed the title [macOS] support Temps, Font; other improvements [macOS] support Temps, Font; Host pretty print; other improvements Sep 25, 2022
@CarterLi
Copy link
Member Author

CarterLi commented Sep 25, 2022

Compare to neofetch (hyfetch)

image

  • Items that fastfetch doesn't support:
  1. GPU driver, which always prints macOS Default Graphics Driver
  • Items that neofetch (hyfetch) doesn't support:
  1. Font
  2. CPU Usage ( cost 1 second though )
  3. Swap
  4. Date & Time
  5. Vulkan
  6. OpenGL
  7. OpenCL
  • Items that fastfetch does better
  1. WM Theme: We correctly prints Multicolor as macOS suggested while neofetch prints Blue
  2. Temperature: We now support macOS
  3. Media: We queries macOS NowPlaying service, thus support most media players

As the latest version 1.7.2 still crashes on Intel MBP, what about a new release?

Copy link
Collaborator

@LinusDierheimer LinusDierheimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work!

Comment on lines +23 to +25
//TODO: do we really need this?
ffStrbufDestroy(&tempValue->name);
ffStrbufDestroy(&tempValue->deviceClass);
Copy link
Collaborator

@LinusDierheimer LinusDierheimer Sep 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do think this belongs here, as this is also the place where the list is being destroyed.

Copy link
Member Author

@CarterLi CarterLi Sep 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant that although we got name and deviceClass but these values were never displayed

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name and deviceClass are used on linux.
name is used to identify which hwmon is the cpu, deviceClass is used by gpu, to map the device class found by libpci to the correct hwmon.

I don't think we need those on apple.

@LinusDierheimer
Copy link
Collaborator

Also i am of the opinion, that temperatures shouldn't be shown by default.

@LinusDierheimer
Copy link
Collaborator

As the latest version 1.7.2 still crashes on Intel MBP, what about a new release?

I want to finish the transition to the new caching mechanism, then i will do a new release.

@LinusDierheimer
Copy link
Collaborator

LinusDierheimer commented Sep 26, 2022

This is pretty big, i will just merge it and let the -git users test it for a while before doing the release.

Code wise it seems fine to me.

@LinusDierheimer LinusDierheimer merged commit 218dffa into fastfetch-cli:master Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants