-
-
Notifications
You must be signed in to change notification settings - Fork 613
[macOS] support Temps, Font; Host pretty print; other improvements #258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Compare to neofetch (hyfetch)
As the latest version 1.7.2 still crashes on Intel MBP, what about a new release? |
LinusDierheimer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work!
| //TODO: do we really need this? | ||
| ffStrbufDestroy(&tempValue->name); | ||
| ffStrbufDestroy(&tempValue->deviceClass); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do think this belongs here, as this is also the place where the list is being destroyed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant that although we got name and deviceClass but these values were never displayed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name and deviceClass are used on linux.
name is used to identify which hwmon is the cpu, deviceClass is used by gpu, to map the device class found by libpci to the correct hwmon.
I don't think we need those on apple.
|
Also i am of the opinion, that temperatures shouldn't be shown by default. |
I want to finish the transition to the new caching mechanism, then i will do a new release. |
The original result format was too Linux specific to make it portable, so I simplified it.
I don't think it's very useful but neofetch support it
eg: --localip-name-prefix en
|
This is pretty big, i will just merge it and let the -git users test it for a while before doing the release. Code wise it seems fine to me. |

Uh oh!
There was an error while loading. Please reload this page.