Skip to content

Conversation

@draumaz
Copy link
Contributor

@draumaz draumaz commented Aug 2, 2022

Logo is once again from @dylanaraps' neofetch.

As a sidenote; I noticed while compiling on KISS, #include <sys/time.h> needs to be included in src/common/networking.c for a successful compile.

While I've only got evidence of the compile failure happening under KISS (perhaps as a side-effect of being musl based, though this behavior isn't reproducible on something like Alpine), is this patch something that might be useful to implement into master?

Below is the failed compile log.

/home/draumaz/kiss-logo/src/common/networking.c: In function 'ffNetworkingGetHtt':
/home/draumaz/kiss-logo/src/common/networking.c:29:24: error: storage size of 'timev' isn't known
   29 |         struct timeval timev;
      |                        ^~~~~
/home/draumaz/kiss-logo/src/common/networking.c:29:24: warning: unused variable timev' [-Wunused-variable]
make[2]: *** [CMakeFiles/libfastfetch.dir/build.make:272: CMakeFiles/libfastfetch.dir/src/common/networking.c.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/Makefile2:87: CMakeFiles/libfastfetch.dir/all] Error 2
make: *** [Makefile:156: all] Error 2

Copy link
Collaborator

@LinusDierheimer LinusDierheimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And please add Kiss to the README.

@LinusDierheimer
Copy link
Collaborator

The time include is fixed.

@LinusDierheimer
Copy link
Collaborator

Thanks, looking good!

@LinusDierheimer LinusDierheimer merged commit b63f419 into fastfetch-cli:master Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants