Timing middleware: add support for alternate message formatters #141
+181
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cahna
force-pushed
the
timing-alternate-formatter
branch
3 times, most recently
from
a8c93b4 to
7aa3372
Compare
cahna
force-pushed
the
timing-alternate-formatter
branch
from
7aa3372 to
9895ae1
Compare
|
This is exactly what I need, I hope it gets merged soon :) @dmontagu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, and thanks for the great library of utils!
I needed support for structured log messages to avoid writing custom parser logic in my app's log aggregation service (Datadog). If you are interested in including such support, this PR is how I implemented that. Backwards-compatible changes:
message_formatterargument toadd_timing_middleware()CONTRIBUTING.mdto referencemake docs-live