Support ZDOTDIR in zsh completion #870
Conversation
chrishepner
force-pushed
the
support-ZDOTDIR
branch
2 times, most recently
from
f6aff9e
to
6a40926
Compare
zsh supports placing its startup files in a directory other than $HOME, [when the user specifies $ZDOTDIR in ~/.zshenv](https://zsh.sourceforge.io/Intro/intro_3.html). typer currently always writes to `~/.zshrc` and `~/.zfunc`. This means that for users that have $ZDOTDIR set to something other than $HOME, `typer --install-completion` has no effect. Update `install_zsh` to install completion to `$ZDOTDIR/.zshrc` and `$ZDOTDIR/.zfunc/` when set.
chrishepner
force-pushed
the
support-ZDOTDIR
branch
from
6a40926
to
7cbb4a3
Compare
|
Hmm, it looks like the absolute |
There was a problem hiding this comment.
Hi, thanks for the PR!
I believe there are ways to use zsh on Windows with Git Bash, though I have no experience with it myself. Either way, the test was working before so it feels like we should be able to get this simple check working on Windows as well.
I double checked on a Windows system to see what was going on, and it seems like the subprocess.run call isn't actually executed properly. The content of new_text is still echo "custom .zshrc" when the assert fails. So I don't think the issue is with fpath.
result.stderr contains the following:
Fatal Python error: _Py_HashRandomization_Init: failed to get random numbers to initialize Python
Which seems to point at an issue with the runtime environment, probably due to the way how you've used mock.patch.dict to make changes to os.environ. Can you think of a different way to run this check?
[UPDATE]: I can indeed use zsh on Windows with Git Bash, so I do think this is a meaningful regression.
zsh supports placing its startup files in a directory other than $HOME, when the user specifies $ZDOTDIR in ~/.zshenv.
typer currently always writes to
~/.zshrcand~/.zfunc. This means that for users that have $ZDOTDIR set to something other than $HOME,typer --install-completionhas no functional effect on the user's shell.Update
install_zshto install completion to$ZDOTDIR/.zshrcand$ZDOTDIR/.zfunc/when set.