🐛 Fix support for UnionType with Python 3.11

[standag]

Resolves #533

[thomasaarholt]

This worked like a charm! Thank you!

[adam-moss]

This is a very nice addition 👍

[coreegor]

Hello everyone,
Is there any plan on having this merged ?
@standag can you set an assignee ?

[standag]

Sorry, I cannot, I haven't write access to this repository.

[peidrao]

The PR seems wonderful, why hasn't it been added yet?

[coreegor]

@standag So you can't set @tiangolo as the assignee ?

[standag]

Who can use this feature
Anyone with write access to a repository can assign issues and pull requests.
https://docs.github.com/en/issues/tracking-your-work-with-issues/assigning-issues-and-pull-requests-to-other-github-users

[disrupted]

also resolves #348

[aronbierbaum]

Are there any updates on this pull request. Would love to not need to use Optional or Union.

[tino]

@disrupted is @tiangolo the only one that can merge? Seems a bit wasteful that this is sitting here with 2 approves and a passing CI just waiting.

[disrupted]

@disrupted is @tiangolo the only one that can merge? Seems a bit wasteful that this is sitting here with 2 approves and a passing CI just waiting.

Looks like it. My review only has symbolic value as I am not a maintainer.

[svlandeg]

Related PR: #548

[sebastian-correa]

Will this be merged anytime soon? @tiangolo

This has become a sore point with Typer in our code.

[svlandeg]

I confirmed that this behaviour works in 3.10 but broke in 3.11, and the unit test introduced in this PR captures the bug nicely.

The fix is very clean and minimal, using the variables from _typing that were introduced precisely for this type of usage.

Thanks for the contribution @standag!

[svlandeg]

Update: #548 now contains all the changes that are also in this PR, as well as a few additional rewrites. As such, I recommend to merge #548 and close this one, but I'll leave the final decision with Tiangolo.

[ml31415]

Looks good. Please merge.

[ml31415]

Dear Sebastian @tiangolo ,
please consider adding one or two trusted persons as maintainers for this package. Python 3.13 is about to come out and this issue for py3.11 is still not fixed, despite long time opened pull requests. I have full understanding for being busy or losing interest in maintenance for a package after a while. But the community is here to help out, to keep this package going. Please just let the community do it's job!

[tiangolo]

Thank you for the work @standag! ☕

And thanks @svlandeg for all the help 🙇

This should have been fixed by #548

It is now available in Typer 0.12.4 🚀

Given that, I'll close this one.