Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ Refactored code to use encryption algorithm name from settings for consistency #1160

Merged
merged 6 commits into from
Sep 27, 2024
Merged

♻️ Refactored code to use encryption algorithm name from settings for consistency #1160

merged 6 commits into from
Sep 27, 2024

Conversation

sameeramin
Copy link
Contributor

No description provided.

@sameeramin sameeramin force-pushed the encryption-algorithm branch 2 times, most recently from 324a7d9 to 4dd0555 Compare April 8, 2024 06:42
@sameeramin sameeramin changed the title 🔧 Refactored code to use encryption algorithm name from settings for consistency ♻️ Refactored code to use encryption algorithm name from settings for consistency Apr 8, 2024
menkotoglou
menkotoglou approved these changes May 8, 2024
View reviewed changes
Copy link

@menkotoglou menkotoglou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

@sameeramin
Copy link
Contributor Author

Thank you @menkotoglou, please let me know what else I need to do in order to get this PR merged.

@menkotoglou
Copy link

@sameeramin unfortunately I cannot do anything about it, since I'm not a repo maintainer.

tiangolo
tiangolo requested changes May 19, 2024
View reviewed changes
Copy link
Member

@tiangolo tiangolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the interest!

I don't think the algorithm should be configurable in the settings, it shouldn't really be variable. Let's better keep it in security.py.

But I agree that the backend utils should use the same variable from security.py. 🤓 Could you please update that?

@sameeramin
Copy link
Contributor Author

Thank you for the interest!

I don't think the algorithm should be configurable in the settings, it shouldn't really be variable. Let's better keep it in security.py.

But I agree that the backend utils should use the same variable from security.py. 🤓 Could you please update that?

Sure, I'll update that!

@sameeramin sameeramin force-pushed the encryption-algorithm branch from 4dd0555 to 33d74b2 Compare May 20, 2024 07:06
@sameeramin
Copy link
Contributor Author

Hello @tiangolo, I have incorporated your suggestions

@tiangolo
Copy link
Member

Great, thanks @sameeramin! 🚀 🍰

@tiangolo tiangolo merged commit 172bfd9 into fastapi:master Sep 27, 2024
10 checks passed
JBLangton pushed a commit to JBLangton/full-stack-fastapi-template that referenced this pull request Mar 29, 2025
@sameeramin @tiangolo
♻️ Refactored code to use encryption algorithm name from settings for…
043354f 
… consistency (fastapi#1160)

Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiangolo tiangolo tiangolo approved these changes

@julioriffel julioriffel julioriffel approved these changes

@menkotoglou menkotoglou menkotoglou approved these changes

Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sameeramin @menkotoglou @tiangolo @julioriffel