This repository has been archived by the owner on Nov 13, 2022. It is now read-only.
Pin pyaml #593
Merged
Pin pyaml #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we don't pin pyaml, people cannot upgrade. The latest version of pyaml makes a breaking change and folks will get the error
TypeError: load() missing 1 required positional argument: 'Loader', this is my mistake as I should have pinned this dependency.Unfortunately, I cannot propagate this fix easily to all fastpages users. This will only fix the issue for new users, which is one of the flaws of fastpages, as certain files like this are permanently "vendored" in without a clean way to upgrade them, since this is the file that drives the upgrading
cc: @tmabraham