feat: new version and tokio local key diags #187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tisonkun
force-pushed
the
tokio-local-set
branch
from
62a9695 to
c66b21e
Compare
tisonkun
commented
Oct 10, 2025
Comment on lines
+115
to
+120
| TASK_LOCAL_MAP.with(|map| { | ||
| let mut map = map.borrow_mut(); | ||
| for (key, value) in this.context.iter() { | ||
| map.push((key.clone(), value.clone())); | ||
| } | ||
| }); |
There was a problem hiding this comment.
This may not be quite efficient. But generally kvs are small and we can anyway improve later.
tisonkun
commented
Oct 10, 2025
Comment on lines
+69
to
+74
| fn with_task_local_context( | ||
| self, | ||
| kvs: impl IntoIterator<Item = (String, String)>, | ||
| ) -> impl Future<Output = Self::Output> | ||
| where | ||
| Self: Sized, |
There was a problem hiding this comment.
I'd prefer a shorter name, but not have a good idea now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #185.