Skip to content

Made random data generation generic. #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lemire merged 2 commits into from
Feb 20, 2023
Merged

Made random data generation generic. #102

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60850ba
Made random data generation generic.
cbsmith Feb 16, 2023
0f3a23d
Fixed data generation to size vector before filling.
cbsmith Feb 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 9 additions & 21 deletions unittest/test_fastpfor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,26 +110,14 @@ namespace FastPForLib {
}
}

void _genDataRandom(std::vector<int32_t>& v, uint32_t values) {
v.clear();
template<typename T>
void _genDataRandom(std::vector<T>& v, uint32_t values) {
v.resize(values);
std::mt19937_64 e2(123456);

@pps83 pps83 Feb 19, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to the PR, but the test might have discovered some hidden issues if it didn't use fixed seed. Perhaps, using device_random or time to seed generator and then, saving the seed is a better approach: If a test fails, then it should report the seed to be able to repro the test case.

@cbsmith cbsmith Feb 19, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems like a good suggestion.

@lemire lemire Feb 20, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that it is most helpful to use fixed seeds.

std::uniform_int_distribution<int32_t> dist(
std::numeric_limits<int32_t>::min(),
std::numeric_limits<int32_t>::max());
for (uint32_t i = 0; i < values; ++i) {
v.push_back(dist(e2));
}
}

void _genDataRandom64(std::vector<int64_t>& v, uint32_t values) {
v.clear();
std::mt19937_64 e2(123456);
std::uniform_int_distribution<int64_t> dist(
std::numeric_limits<int64_t>::min(),
std::numeric_limits<int64_t>::max());
for (uint32_t i = 0; i < values; ++i) {
v.push_back(dist(e2));
}
std::uniform_int_distribution<T> dist(
std::numeric_limits<T>::min(),
std::numeric_limits<T>::max());
std::generate_n(std::begin(v), values, std::bind(dist, e2));
}

void _genDataWithFixBits(
Expand Down Expand Up @@ -179,7 +167,7 @@ namespace FastPForLib {
}

TEST_P(FastPForTest, randomNumbers64) {
_genDataRandom64(in64, 65536);
_genDataRandom(in64, 65536);
_verify64();
}

Expand Down Expand Up @@ -239,7 +227,7 @@ namespace FastPForLib {
}

TEST_P(FastPForTest, fastpack_min_max64) {
_genDataRandom64(in64, 256);
_genDataRandom(in64, 256);
in64[0] = std::numeric_limits<int64_t>::min();
in64[127] = std::numeric_limits<int64_t>::max();
in64[128] = std::numeric_limits<int64_t>::min();
Expand Down