Open
Conversation
Fixed the issue of deprecated github URL for influxdata
Since the program is running behind an Nginx proxy, the requester's IP has been corrected by using "X-Forwarded-For" and "X-Real-Ip" headers.
This was referenced Feb 9, 2019
Owner
Author
|
The idea of excluding private IP was because the client might forward private IP in the chain of proxies that the client itself is using. Perhaps it is a good idea to have an enable and disable the option that is read from the config file to filter out private IP? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed on Issue #10 where the Nginx proxy is not passing real IP to hlswatch.
This is fixed by making Nginx attach the original requester's IP to the X headers.
hlswatch then read these headers and extract the real IP.
Fixed on docker build problem #7