Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using new version of Font Awesome Fre 6.5.2 #586

Merged
merged 1 commit into from
Aug 11, 2024

Conversation

brocasm
Copy link
Contributor

@brocasm brocasm commented Jul 15, 2024

Just swap old version (5.15.3) by new one (6.5.2)

Testing test app without problem, no more testing.

Now we have all newest icons available.

@brocasm
Copy link
Contributor Author

brocasm commented Aug 11, 2024

@farridav can you approve or comment this pull request ?
What can i do better ?

@farridav
Copy link
Owner

Makes sense

@farridav farridav merged commit e586f7b into farridav:master Aug 11, 2024
@Huge
Copy link

Huge commented Aug 30, 2024

I'd update the Readme accordingly, but the v6 icons in the side-bar/menu act really weird in my case.
image - the icons applied to users and groups, but fail to display on all other model admin items.

My settings:

single_uniform_icon = "fab fa-microsoft"

# Jazzmin Settings
JAZZMIN_SETTINGS = {
    "dark_mode_theme": "darkly",  # Ensure dark mode theme is set
    "default_icon_children": single_uniform_icon,
    "default_icon_parent": single_uniform_icon,
    "icons": {
        # "auth": "fas fa-users-cog",
        "auth.user": single_uniform_icon, # default was "fas fa-user" and "fas fa-users", gets back if this gets removed..
        "auth.Group": single_uniform_icon,
    },
      #...
    ```

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants