Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix again the strategy for determining the latest version released. #565

Conversation

PacificGilly
Copy link
Collaborator

@PacificGilly PacificGilly commented Apr 18, 2024

Since we want to auto-publish the a test version of Django Jazzmin each time a PR is merged, we have to take into account the following:

  • You need to know which test versions have already been released on test PyPi so, between production releases, you don't have tag clashes.
  • When a production version is released to PyPi you need to start releasing test version using the new production version. Otherwise you'll stay on the initial version constantly.

Before

Test Version Production Version
2.6.2a0 2.6.2
2.6.2a1 2.6.2
2.6.2a1 2.7.0
2.6.2a2 2.7.0

After

Test Version Production Version
2.6.2a0 2.6.2
2.6.2a1 2.6.2
2.6.2a1 2.7.0
2.6.7a0 2.7.0

Since we want to auto publish the a test version of Django Jazzmin each
time a PR is merged we have to take into account to things:
* You need to know which test versions have already been released on
  test PyPi so between prooduction releases you don't have tag clashes.
* When a production version is released to PyPi you need to start
  releasing test version using the new production version. Otherwise
  you'll stay on the initial version constantly.
@PacificGilly PacificGilly requested a review from farridav April 18, 2024 19:49
@PacificGilly PacificGilly self-assigned this Apr 18, 2024
@farridav
Copy link
Owner

Quite complex, but I understand the rationale, and it seems to behave as expected.

@PacificGilly
Copy link
Collaborator Author

PacificGilly commented Apr 22, 2024

Quite complex, but I understand the rationale, and it seems to behave as expected.

@farridav Yeah, sadly not an elegant solution, but does the trick. Did you have a better solution or are you happy for me to merge?

@farridav
Copy link
Owner

No let's get this moving, thanks for the work on it

@farridav farridav merged commit 19cbb0e into farridav:master Apr 22, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants