Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

length_is removed in Django 5.1 #519

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

jameslao
Copy link
Contributor

length_is is deprecated since 4.2 and removed in Django 5.1

@FabianClemenz
Copy link

need this too! :)

@AndrewManHayChiu
Copy link

Would really like this too.

Django issued security release in July, and I took this as an opportunity to upgrade to 5.1.

This pull request is very minor, so hoping it can be merged sooner rather than later!

@linhfishCR7
Copy link

linhfishCR7 commented Sep 3, 2024

It is so good. Please merge it!

@talesmm14
Copy link

I need this too!

@olegasics
Copy link

@pjrobertson
Copy link

@farridav - can this PR be bumped up the priority list? length_is was deprecated in December 2023 and is now removed from Django 5.1. Breaking compatibility with jazzmin + Django 5.1+

@farridav
Copy link
Owner

Sure I'll get to this today 😄

@farridav farridav merged commit 097720d into farridav:master Sep 11, 2024
@pjrobertson
Copy link

Amazing, thank you!! 🙏🎉

@FabianClemenz
Copy link

@farridav when will the next release come to deploy this?

@syphar
Copy link

syphar commented Oct 8, 2024

@farridav sorry for the ping, also wanted to ask for a release.

How can we / I help to make this happen? Testing? Reviewing? Other fixes?

@farridav
Copy link
Owner

farridav commented Oct 8, 2024

Apologies, I've been unusually busy lately with other commitments, and I think the other guy that was helping out with issues might also be a little busy.

Let me out a release out now, in terms of help, I think what I need most is help triaging and reviewing, every time I get 5 minutes to look at GitHub, it seems like an overwhelming backlog (though probably it's mostly stale).

Expect a pypi release within the hour, and I'll open an issue regarding contributors to try and rally support

@FabianClemenz
Copy link

thanks @farridav in terms of help - if i have time i would be happy to review some stuff and help you out

@farridav
Copy link
Owner

farridav commented Oct 8, 2024

I'm actually having issues with the build at the moment, that is preventing a release, I'll keep this open on my terminal to try and get it sorted ASAP

@farridav
Copy link
Owner

farridav commented Oct 8, 2024

Release issues fixed and 3.0.1 is available on pypi...

Lots more to do here I realise, I'm keen to get back on top of it all, and will definitely take you up on your offer to help :)

@FabianClemenz
Copy link

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants