Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for hu locale #201

Merged

Conversation

kristofgilicze
Copy link
Contributor

  • added translations for hungarian.
  • removed the extra strings with the cli tool ( as requested in dev docs )
  • added 'hu' locale to options

@TysonRV
Copy link
Contributor

TysonRV commented Nov 4, 2020

Hi @kristofgilicze !

Thanks for the PR, it's great to be able to jazz up the admin in Hungarian too!

Note that some of the strings that are on that po file are coming directly from Django. You could just run ./cli.py locales --prune hu to remove all of them and make it easier to maintain in the future.

I'll merge the PR once that's done 😄

@TysonRV TysonRV self-requested a review November 4, 2020 20:36
@kristofgilicze
Copy link
Contributor Author

Hello !

I did ran the tool, it removed at least 400 lines from django.po.
So either the tool is broken or my env ?

If all else fails, then I can manually compare with the other languages.

@TysonRV
Copy link
Contributor

TysonRV commented Nov 4, 2020

@kristofgilicze Hey!
You are actually right. The problem is that we have started supporting now other apps, e.g, django-import-export, and there are some translations coming from those which we didn't count on initially.

This will require some further investigation, so I will merge this PR already to keep things moving.

Thanks again 🙂

@TysonRV TysonRV merged commit e934e04 into farridav:master Nov 4, 2020
minholi pushed a commit to minholi/django-jazzmin that referenced this pull request Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants