Add critical sections to STM32WL radio driver (resolves nathan/edg-532) #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brightbloom
requested changes
Feb 26, 2025
There was a problem hiding this comment.
Based on reading the linked ST issue and their code on GitHub, I believe adding this code is not going to help us.
They're using a dual-core system where the inter-core comms were getting locked up because of a poorly designed IPC system. We don't have a second core. This code will, if it functions as I expect, do nothing.
Is there some other case you can think of in which adding a critical section here could help?
|
@diggerdata please provide feedback on this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug discovered here that was resolved in Cube FW 1.3.2. See https://community.st.com/t5/stm32-mcus-wireless/stm32wl-ipc-communication-failure-hangs-the-application-from/td-p/680514