fix(grokbuild): bind session summaries to custom provider profiles - #7004
Open
enderzcx wants to merge 1 commit into
Open
fix(grokbuild): bind session summaries to custom provider profiles#7004enderzcx wants to merge 1 commit into
enderzcx wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary / 概述
Grok Build chooses the model for session titles/summaries independently of the main session (
models.session_summaryvsmodels.default). Generated custom-provider configs currently omit the former, so a working custom-model conversation can still issue a title request to the client's fallback model.This focused fix uses the existing configuration builders:
models.session_summaryto the selected profile when generating Grok Build deep-link and form configurations.No new UI, dependency, model catalog changes, credential-resolution changes, API retries, or provider protocol changes. Existing deep-link
env_keyprotections are unchanged and their tests still pass.Reference: Grok Build model configuration.
Related Issue / 关联 Issue
Fixes #7003
Verification / 验证
Run locally on macOS:
pnpm typecheck— PASS.pnpm format:check— PASS.pnpm exec vitest run src/utils/grokBuildConfig.test.ts tests/components/GrokBuildProviderForm.test.tsx tests/utils/deepLinkConfigPreview.test.ts --reporter=dot— 21 PASS.cd src-tauri && cargo fmt --check— PASS.cargo test --locked --lib deeplink::provider::tests::grokbuild --no-fail-fast— 3 PASS, including both existing credential-import regression tests. The new test covers selected, trimmed, namespaced, absent and blank-model behavior through the configuration builder.cargo clippy --locked --all-targets --all-features— PASS.git diff --check— PASS.The new assertions were first run against the original builders: four TypeScript checks and the Rust summary-field check failed because the field was missing. They pass with this patch.
Full frontend suite:
pnpm test:unit --maxWorkers=2 --minWorkers=1ran 1,016 tests: 1,014 passed, 2 failed in the unchangedtests/config/codexReasoningLevelPresets.test.ts(xAI (Grok)andxAI (Grok) OAuth,grok-4.5: actual reasoning levels includexhigh, expected levels do not). Both failures were reproduced in a separate unmodified054673e0b8cca7d8bd8c67658f2c28e63b2855e0worktree by running that file: 38 passed, the same 2 failed. No reasoning catalog or unrelated test assertions were changed.This is a config-generation regression fix, not a claim of complete desktop GUI or cross-platform acceptance. The patch was AI-assisted; the code and changes were reviewed and the checks above were actually run locally.
Screenshots / 截图
Not applicable: no visual changes.
Checklist / 检查清单
pnpm typecheckpasses / 通过 TypeScript 类型检查pnpm format:checkpasses / 通过代码格式检查cargo clippypasses (if Rust code changed) / 通过 Clippy 检查