This repository was archived by the owner on Jan 11, 2021. It is now read-only.
Open
Conversation
Author
|
Hey! Haven't been using SmartOptimizer for a while. But I'm rolling out a few big changes on my website, and I will launch a new project soon, and I'm wondering if I should use this lib or not :) Is anyone still on the line? |
Author
|
Oh darn it I closed the issue :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I like the library and added grouping functionality. (01ebb76)
Namely, you can specify groups of files (that can be in different dirs) and SmartOptimizer will concat and min them. In this way, you can call a group of files by doing http://example.com/group.main.js/
Use cases: add/remove files easily from any group
Use one group for app-wide files, another for module-wide files = only 2 requests.
I also used deanedwards' packer for js minification. I've added the option to use custom minifiers, in a separate commit.(852b4df)
The other 3 commits are bug fixes and a merge.