Line breaking happening at 96 print width?

[vincerubinetti]

Not sure if this is related to #8 ?

95 characters:

96 characters:

I'd expect it to wrap such that no characters (including the comment characters) exceed the print width (shown in the screenshot with the vertical line).

This is my .prettierrc:

{
  "plugins": ["./node_modules/prettier-plugin-jsdoc"],
  "jsdocCapitalizeDescription": false,
}

No override of the default printWidth of 80, so it should be 80. Also the rest of my code formats properly to 80.

[ahmafi]

I have a problem related to printWidth since it might be related to the same problem, I'll post it here for now. I get line break on 90-91 characters, but I have the default setting which is 80 characters. I have no other special options. I don't have this problem on the same line of the tag definition (lines 8 and 10 in the image below).

[vincerubinetti]

Does anyone know who the main maintainer(s) of this are? @HosseinMD? Any info about this? I don't know about others, but this line-wrapping is like the main point of using this extension at all, so it's not good that it doesn't work as expected.

I'd be happy to look into doing a PR for this. 770e213 seems to be a likely culprit, though I don't understand how it would create breaking at 96.

[vincerubinetti]

Something I just realized is that this bug seems to only happen if it's the last line of a comment:

For the non-last lines, it correctly catches and fixes lines that go over the print width.

[vincerubinetti]

Okay, according to this comment, I guess this was actually a feature:

#26 (comment)

I was going to say that this was a weird error in judgement. I don't know of any word processor that tries to "smart" wrap like this. MS Word doesn't do it. VSCode's word wrap doesn't do it. Etc.

However, apparently Prettier does sort of do it:

In other words, don’t try to use printWidth as if it was ESLint’s max-len – they’re not the same. max-len just says what the maximum allowed line length is, but not what the generally preferred length is – which is what printWidth specifies.

Despite all this, I wish there was a way to disable this behavior. I would like to just have it hard wrap at printWidth always. I really think this looks stupid and is unexpected:

Also, I can't verify this, but it seems like Prettier does actually hard wrap at printWidth whenever possible, but sometimes it's not able to, e.g a long string literal, hence why they say it sometimes produces lines over the printWidth.

[ahmafi]

I don't like this feature too, I prefer a new line even if it's only 1 word on the new line, so I have more consistency in my line widths. But since this is implemented and some people want this, maybe we can turn this into an option that can be configured.

[fardad-dev]

We need a paragraph balancer algorithm. Something which can keep lines smaller than print width, But about the same size

For Example:

Lorem ipsum is a placeholder text commonly used to demonstrate the visual form of a document or a 
typeface withoutrelying on meaningful content.

Should be:

Lorem ipsum is a placeholder text commonly used to demonstrate the visual 
form of a document or a typeface without relying on meaningful content.

[vincerubinetti]

We need a paragraph balancer algorithm.

Why? Does Prettier do this with prose? It certainly doesn't seem to do it with code. I think this is over-complicating it. I, and I think a lot of others, will just want dead simple line wrapping. Go line by line and start a new line the very second a line goes over the print width. Is it possible to get an option for this?

[fardad-dev]

Option for what?

[fardad-dev]

There is a package which @egilll suggested https://github.com/nginz/fair-lines .

[vincerubinetti]

I'm saying, please just make it like this, or give us an option for this 👇

Lorem ipsum is a placeholder text commonly used to demonstrate the visual form of a document or a |
typeface withoutrelying on meaningful content.                                                    |

This is unnecessary 👇

Lorem ipsum is a placeholder text commonly used to demonstrate the visual                  |
form of a document or a typeface without relying on meaningful content.                    |

[fardad-dev]

what about this

Lorem ipsum is a placeholder text commonly used to demonstrate the visual form of a document or a 
all.

[egilll]

I have a fix for this issue (along with several other line-wrapping bugs) in a fork I've been working on, I'll try to submit it within 2 weeks.

[vincerubinetti]

what about this

Lorem ipsum is a placeholder text commonly used to demonstrate the visual form of a document or a 
all.

Yes, that is fine!

I understand the issue completely. I just want simple word wrapping, like most word processors do:

I am willing to bet most other people are just looking for this too. I dont see a reason to make it so complicated with the "fair lines". It's cool if you want to add that, but please also include an option for just basic/simple word wrapping.

[fardad-dev]

I have a fix for this issue (along with several other line-wrapping bugs) in a fork I've been working on, I'll try to submit it within 2 weeks.

Could you create a Quick PR just for this.

[fardad-dev]

what about this

Lorem ipsum is a placeholder text commonly used to demonstrate the visual form of a document or a 
all.

Yes, that is fine, to me.

I understand the issue completely. I just want simple word wrapping, like most word processors do:

I am willing to bet most other people are just looking for this too. I dont see a reason to make it so complicated with the "fair lines". It's cool if you want to add that, but an option for simple word wrapping would be greatly appreciated.

Ok. I Will do it as you want this weekend.