Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: snapchain migration #2443

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

WIP: snapchain migration #2443

wants to merge 9 commits into from

Conversation

aditiharini
Copy link
Contributor

@aditiharini aditiharini commented Dec 16, 2024

Why is this change needed?

Describe why this issue should be fixed and link to any relevant design docs, issues or other relevant items.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review


PR-Codex overview

This PR introduces new functionality for pruning messages in the system, including new requests and responses in the protocol, updates to various services, and enhancements to the migration process.

Detailed summary

  • Added PruneMessagesRequest and PruneMessagesResponse messages in protobufs/schemas/request_response.proto.
  • Implemented PruneMessages RPC method in protobufs/schemas/rpc.proto.
  • Added clearCachedMessageCount and clearStorageCacheForFid methods in relevant files.
  • Updated DEFAULT_PRUNE_MESSAGES_JOB_CRON to run every 5 minutes.
  • Enhanced logging for message pruning operations.
  • Modified submitUserNameProof and pruneMessages in apps/hubble/src/rpc/adminServer.ts.
  • Introduced ingestMessagesFromDb method in Migration class for processing messages.
  • Updated CLI options to include parameters for stopping message transfers.
  • Adjusted message reconciliation logic to utilize new pruning logic.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Dec 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 8:00pm

Copy link

socket-security bot commented Dec 16, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

Copy link

changeset-bot bot commented Dec 16, 2024

⚠️ No Changeset found

Latest commit: fae35e7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants