Skip to content

Conversation

horsefacts
Copy link
Collaborator

@horsefacts horsefacts commented Jun 2, 2025

Motivation

Batch credit for existing tier payments without token transfer.

Change Summary

  • Reuse Migration abstract contract
  • Add batchCreditTier to credit tier without payment
  • Add sweepERC20 to rescue ERC20 balance

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review


PR-Codex overview

This PR enhances the IMigration interface and related contracts, introducing a migration mechanism and improving tier management. It also updates test cases to ensure proper functionality of the new features.

Detailed summary

  • IMigration now extends IGuardians.
  • ITierRegistry extends IMigration.
  • Added batchCreditTier function in ITierRegistry.
  • Introduced SweepToken event in ITierRegistry.
  • Updated TierRegistry constructor to accept migrator address.
  • Modified pause and unpause functions to sweepToken.
  • Updated test cases to cover new migration and batch credit functionalities.

The following files were skipped due to too many changes: .gas-snapshot

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@horsefacts horsefacts added the feat New feature request label Jun 2, 2025
@horsefacts horsefacts force-pushed the horsefacts/tier-batch-credit branch 2 times, most recently from 101c53e to d4154d8 Compare June 2, 2025 22:47
@horsefacts horsefacts force-pushed the horsefacts/tier-batch-credit branch from d4154d8 to fd548fa Compare June 2, 2025 22:55
Copy link

github-actions bot commented Jun 2, 2025

Coverage after merging horsefacts/tier-batch-credit into main will be

100.00%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   Bundler.sol100%100%100%100%
   BundlerV1.sol100%100%100%100%
   FnameResolver.sol100%100%100%100%
   IdGateway.sol100%100%100%100%
   IdRegistry.sol100%100%100%100%
   KeyGateway.sol100%100%100%100%
   KeyRegistry.sol100%100%100%100%
   RecoveryProxy.sol100%100%100%100%
   StorageRegistry.sol100%100%100%100%
   TierRegistry.sol100%100%100%100%
src/abstract
   EIP712.sol100%100%100%100%
   Guardians.sol100%100%100%100%
   Migration.sol100%100%100%100%
   Nonces.sol100%100%100%100%
   Signatures.sol100%100%100%100%
src/validators
   SignedKeyRequestValidator.sol100%100%100%100%

@horsefacts horsefacts merged commit 7fc08c6 into main Jun 2, 2025
4 checks passed
@horsefacts horsefacts deleted the horsefacts/tier-batch-credit branch June 2, 2025 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat New feature request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant