Skip to content

Conversation

horsefacts
Copy link
Collaborator

@horsefacts horsefacts commented May 28, 2025

Motivation

Enable callers to atomically register multiple keys (like a signer and auth address) in a single call.

Change Summary

  • Add external addKeys to Bundler
  • Rename old Bundler contract BundlerV1
  • Add deploy script + test

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review


PR-Codex overview

This PR introduces BundlerV1, an updated version of the Bundler contract, along with a new interface IBundlerV1. It adds functionality for adding multiple keys in a single transaction and updates various tests and deployment scripts to accommodate the new version.

Detailed summary

  • Added addKeys function to IBundlerV1 for batch key addition.
  • Updated Bundler to BundlerV1 in multiple test files and deployment scripts.
  • Changed version constant in Bundler from "2023.11.15" to "2025.06.13".
  • Introduced BundlerV1 contract implementing IBundlerV1.
  • Updated tests to use IBundlerV1 and BundlerV1.
  • Created BundlerV1TestSuite for testing the new bundler functionality.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@horsefacts horsefacts changed the title feat: add addKey to Bundler feat: add addKeys to Bundler May 28, 2025
@horsefacts horsefacts added the feat New feature request label May 28, 2025
@horsefacts horsefacts force-pushed the horsefacts/key-bundler branch from bc315ee to e77777a Compare June 2, 2025 20:28
Copy link

github-actions bot commented Jun 2, 2025

Coverage after merging horsefacts/key-bundler into main will be

100.00%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   Bundler.sol100%100%100%100%
   BundlerV1.sol100%100%100%100%
   FnameResolver.sol100%100%100%100%
   IdGateway.sol100%100%100%100%
   IdRegistry.sol100%100%100%100%
   KeyGateway.sol100%100%100%100%
   KeyRegistry.sol100%100%100%100%
   RecoveryProxy.sol100%100%100%100%
   StorageRegistry.sol100%100%100%100%
   TierRegistry.sol100%100%100%100%
src/abstract
   EIP712.sol100%100%100%100%
   Guardians.sol100%100%100%100%
   Migration.sol96.97%80%100%100%40
   Nonces.sol100%100%100%100%
   Signatures.sol100%100%100%100%
src/validators
   SignedKeyRequestValidator.sol100%100%100%100%

@horsefacts horsefacts merged commit e57706e into main Jun 2, 2025
4 checks passed
@horsefacts horsefacts deleted the horsefacts/key-bundler branch June 2, 2025 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat New feature request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant