Skip to content

Conversation

horsefacts
Copy link
Collaborator

@horsefacts horsefacts commented May 15, 2025

Change Summary

Add fork tests for indexed auth keys.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review


PR-Codex overview

This PR focuses on modifying the registration of authentication keys in the AuthKeysTest contract, specifically changing how auth keys are created and registered with different indices.

Detailed summary

  • Updated the creation of the auth key to include an index in authKey.
  • Registered an auth key with index 0 using bytes.concat.
  • Added functionality to register a new auth key with index 1.
  • Created a new signature and metadata for the auth key with index 1.
  • Added the new auth key to the keyGateway and verified its state.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

Coverage after merging horsefacts/indexed-auth-keys into main will be

100.00%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   Bundler.sol100%100%100%100%
   FnameResolver.sol100%100%100%100%
   IdGateway.sol100%100%100%100%
   IdRegistry.sol100%100%100%100%
   KeyGateway.sol100%100%100%100%
   KeyRegistry.sol100%100%100%100%
   RecoveryProxy.sol100%100%100%100%
   StorageRegistry.sol100%100%100%100%
src/abstract
   EIP712.sol100%100%100%100%
   Guardians.sol100%100%100%100%
   Migration.sol96.97%80%100%100%40
   Nonces.sol100%100%100%100%
   Signatures.sol100%100%100%100%
src/validators
   SignedKeyRequestValidator.sol100%100%100%100%

@horsefacts horsefacts added the chore A task that is none of the other types label May 15, 2025
@horsefacts horsefacts merged commit 6058557 into main May 15, 2025
4 checks passed
@horsefacts horsefacts deleted the horsefacts/indexed-auth-keys branch May 15, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore A task that is none of the other types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant