Skip to content

Conversation

horsefacts
Copy link
Collaborator

@horsefacts horsefacts commented May 13, 2025

Motivation

The behavior of the forge fmt code formatter has changed since we last touched the contracts repo. Rather than fight the formatter, we should adopt standard style.

Change Summary

Update foundry to latest stable and run forge fmt to reformat existing code.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review


PR-Codex overview

This PR primarily focuses on improving the formatting of function signatures across various Solidity files. It enhances readability by aligning parameters vertically.

Detailed summary

  • Updated function signatures to have parameters on new lines for readability in multiple files.
  • Adjusted setMigrator, price, runDeploy, hashTypedDataV4, and other functions to follow this style.
  • Modified several test functions similarly for consistency.
  • Made minor adjustments to the Dockerfile to install netcat-openbsd instead of netcat.
  • Updated CI workflow to use stable version of Foundry instead of nightly.

The following files were skipped due to too many changes: test/StorageRegistry/StorageRegistry.t.sol

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@horsefacts horsefacts added the chore A task that is none of the other types label May 13, 2025
@horsefacts horsefacts force-pushed the horsefacts/reformat branch from fa94c1d to c1bf00f Compare May 13, 2025 23:48
@horsefacts horsefacts force-pushed the horsefacts/reformat branch from 4eb0c7b to de9ab37 Compare May 14, 2025 04:45
@horsefacts horsefacts force-pushed the horsefacts/reformat branch from 010cd28 to 6af5212 Compare May 14, 2025 05:31
@horsefacts horsefacts force-pushed the horsefacts/reformat branch 2 times, most recently from c89546b to c941c07 Compare May 14, 2025 07:20
@horsefacts horsefacts force-pushed the horsefacts/reformat branch from c941c07 to 35c5856 Compare May 14, 2025 07:22
@horsefacts horsefacts force-pushed the horsefacts/reformat branch from 026f312 to b5370b5 Compare May 14, 2025 14:08
Copy link

Coverage after merging horsefacts/reformat into main will be

100.00%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   Bundler.sol100%100%100%100%
   FnameResolver.sol100%100%100%100%
   IdGateway.sol100%100%100%100%
   IdRegistry.sol100%100%100%100%
   KeyGateway.sol100%100%100%100%
   KeyRegistry.sol100%100%100%100%
   RecoveryProxy.sol100%100%100%100%
   StorageRegistry.sol100%100%100%100%
src/abstract
   EIP712.sol100%100%100%100%
   Guardians.sol100%100%100%100%
   Migration.sol96.97%80%100%100%40
   Nonces.sol100%100%100%100%
   Signatures.sol100%100%100%100%
src/validators
   SignedKeyRequestValidator.sol100%100%100%100%

@horsefacts horsefacts merged commit 40777f8 into main May 14, 2025
4 checks passed
@horsefacts horsefacts deleted the horsefacts/reformat branch May 14, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore A task that is none of the other types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant