Refactor: Improve reliability of peerd connections #792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to consistently inform the user on the connection status of the swap. Peerd now emits Disconnected and Reconnected requests to farcasterd, which in turn can route them on to swapd.
The connect command now allows a user to manually trigger a connect for a restored swap that was previously unable to connect.
was calling colorize func, not swap_id itself
Handle Connect msg properly for running and restoring swapd Peerd: Add a Pong to our own hacky handshake Peerd: Only insert protocol messages to unchecked_msg_cache
Farcaster: Correct handling of restoring tsm connection
Ensure ConnectSuccess message is only expected for Taker swaps Handle new and failed connections in a coherent manner Trigger peerd termination externally, not internally
log swapids if awaiting connection
Peerd: Emit Reconnected only after checking cached messages Do not reconnect as a listener-spawned peerd
This was referenced Nov 28, 2022
sedited
added
refactor
farcaster.dev testing
sedited
changed the title
h4sh3d
reviewed
Nov 29, 2022
Member
h4sh3d
left a comment
h4sh3d
left a comment
There was a problem hiding this comment.
Currently testing swaps against fc.dev. This is my first round of review.
I can see this in my logs, not sure what triggers it and if it is related to this work or not:
[2022-11-29T10:18:23Z WARN farcaster_node::swapd::swap_state] Not on RefundSig state
This is happening as Bob.
Member
Author
This is unrelated, it's also logged on main. |
h4sh3d
reviewed
Nov 30, 2022
Member
h4sh3d
left a comment
h4sh3d
left a comment
There was a problem hiding this comment.
Last round, mostly minor comments, feel free to discard the ones that you consider not important.
h4sh3d
approved these changes
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes: