Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zoneinfo issues for Python versions 3.9 and below #2

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

BrQE
Copy link

@BrQE BrQE commented Jan 18, 2024

fixed zoneinfo issues for Python versions 3.9 and below.

@BrQE BrQE changed the title fixed zoneinfo issues for Python versions 3.9 and below. zoneinfo issues for Python versions 3.9 and below. Jan 18, 2024
@BrQE BrQE changed the title zoneinfo issues for Python versions 3.9 and below. zoneinfo issues for Python versions 3.9 and below Jan 18, 2024
@farahats9
Copy link
Owner

farahats9 commented Jan 18, 2024

Thank you for your contribution, zoneinfo is already supported in Python 3.9+
This appears to add an external package backports.zoneinfo and it needs to be conditional based on python version for 3.8 and below only, can you update you PR to add these changes?

@BrQE
Copy link
Author

BrQE commented Jan 18, 2024

Of cource, updated PR, I thank you, especially, for deciding to update this library.

@farahats9
Copy link
Owner

Sorry I wasn't clear, your original code was correct. I meant it should be added in the setup.py and the requirements files as a conditional based on the version of python it should install these backports dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants