Collapse duplicate suffixes (fixes #2) #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a strange pattern that appears in a lot of databases: Sometimes two address fields will contain redundant data, and sometimes they won't. I don't really like this code, because it feels hackish, but it seems to do what people want. I'm curious about whether we should do something similar with prefixes.
We need to run this somewhere that we have a copy of `cargo deny check`.
seamusabshere
approved these changes
Mar 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a strange pattern that appears in a lot of databases: Sometimes
two address fields will contain redundant data, and sometimes they
won't. I don't really like this code, because it feels hackish, but it
seems to do what people want.
I'm curious about whether we should do something similar with prefixes.