Skip to content

Commit

Permalink
Merge remote-tracking branch 'robh/for-next' into devicetree/next
Browse files Browse the repository at this point in the history
Conflicts:
	drivers/of/unittest.c
  • Loading branch information
glikely committed Mar 29, 2015
2 parents 37791b6 + 01218bf commit a2166ca
Show file tree
Hide file tree
Showing 47 changed files with 528 additions and 494 deletions.
44 changes: 22 additions & 22 deletions Documentation/devicetree/bindings/unittest.txt
Original file line number Diff line number Diff line change
@@ -1,60 +1,60 @@
1) OF selftest platform device
1) OF unittest platform device

** selftest
** unittest

Required properties:
- compatible: must be "selftest"
- compatible: must be "unittest"

All other properties are optional.

Example:
selftest {
compatible = "selftest";
unittest {
compatible = "unittest";
status = "okay";
};

2) OF selftest i2c adapter platform device
2) OF unittest i2c adapter platform device

** platform device unittest adapter

Required properties:
- compatible: must be selftest-i2c-bus
- compatible: must be unittest-i2c-bus

Children nodes contain selftest i2c devices.
Children nodes contain unittest i2c devices.

Example:
selftest-i2c-bus {
compatible = "selftest-i2c-bus";
unittest-i2c-bus {
compatible = "unittest-i2c-bus";
status = "okay";
};

3) OF selftest i2c device
3) OF unittest i2c device

** I2C selftest device
** I2C unittest device

Required properties:
- compatible: must be selftest-i2c-dev
- compatible: must be unittest-i2c-dev

All other properties are optional

Example:
selftest-i2c-dev {
compatible = "selftest-i2c-dev";
unittest-i2c-dev {
compatible = "unittest-i2c-dev";
status = "okay";
};

4) OF selftest i2c mux device
4) OF unittest i2c mux device

** I2C selftest mux
** I2C unittest mux

Required properties:
- compatible: must be selftest-i2c-mux
- compatible: must be unittest-i2c-mux

Children nodes contain selftest i2c bus nodes per channel.
Children nodes contain unittest i2c bus nodes per channel.

Example:
selftest-i2c-mux {
compatible = "selftest-i2c-mux";
unittest-i2c-mux {
compatible = "unittest-i2c-mux";
status = "okay";
#address-cells = <1>;
#size-cells = <0>;
Expand All @@ -64,7 +64,7 @@ Example:
#size-cells = <0>;
i2c-dev {
reg = <8>;
compatible = "selftest-i2c-dev";
compatible = "unittest-i2c-dev";
status = "okay";
};
};
Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
Open Firmware Device Tree Selftest
Open Firmware Device Tree Unittest
----------------------------------

Author: Gaurav Minocha <gaurav.minocha.os@gmail.com>

1. Introduction

This document explains how the test data required for executing OF selftest
This document explains how the test data required for executing OF unittest
is attached to the live tree dynamically, independent of the machine's
architecture.

Expand All @@ -22,31 +22,31 @@ most of the device drivers in various use cases.

2. Test-data

The Device Tree Source file (drivers/of/testcase-data/testcases.dts) contains
The Device Tree Source file (drivers/of/unittest-data/testcases.dts) contains
the test data required for executing the unit tests automated in
drivers/of/selftests.c. Currently, following Device Tree Source Include files
(.dtsi) are included in testcase.dts:
drivers/of/unittest.c. Currently, following Device Tree Source Include files
(.dtsi) are included in testcases.dts:

drivers/of/testcase-data/tests-interrupts.dtsi
drivers/of/testcase-data/tests-platform.dtsi
drivers/of/testcase-data/tests-phandle.dtsi
drivers/of/testcase-data/tests-match.dtsi
drivers/of/unittest-data/tests-interrupts.dtsi
drivers/of/unittest-data/tests-platform.dtsi
drivers/of/unittest-data/tests-phandle.dtsi
drivers/of/unittest-data/tests-match.dtsi

When the kernel is build with OF_SELFTEST enabled, then the following make rule

$(obj)/%.dtb: $(src)/%.dts FORCE
$(call if_changed_dep, dtc)

is used to compile the DT source file (testcase.dts) into a binary blob
(testcase.dtb), also referred as flattened DT.
is used to compile the DT source file (testcases.dts) into a binary blob
(testcases.dtb), also referred as flattened DT.

After that, using the following rule the binary blob above is wrapped as an
assembly file (testcase.dtb.S).
assembly file (testcases.dtb.S).

$(obj)/%.dtb.S: $(obj)/%.dtb
$(call cmd, dt_S_dtb)

The assembly file is compiled into an object file (testcase.dtb.o), and is
The assembly file is compiled into an object file (testcases.dtb.o), and is
linked into the kernel image.


Expand Down Expand Up @@ -98,7 +98,7 @@ child11 -> sibling12 -> sibling13 -> sibling14 -> null
Figure 1: Generic structure of un-flattened device tree


Before executing OF selftest, it is required to attach the test data to
Before executing OF unittest, it is required to attach the test data to
machine's device tree (if present). So, when selftest_data_add() is called,
at first it reads the flattened device tree data linked into the kernel image
via the following kernel symbols:
Expand Down
9 changes: 9 additions & 0 deletions MAINTAINERS
Original file line number Diff line number Diff line change
Expand Up @@ -7187,6 +7187,15 @@ F: Documentation/devicetree/
F: arch/*/boot/dts/
F: include/dt-bindings/

OPEN FIRMWARE AND DEVICE TREE OVERLAYS
M: Pantelis Antoniou <pantelis.antoniou@konsulko.com>
L: devicetree@vger.kernel.org
S: Maintained
F: Documentation/devicetree/dynamic-resolution-notes.txt
F: Documentation/devicetree/overlay-notes.txt
F: drivers/of/overlay.c
F: drivers/of/resolver.c

OPENRISC ARCHITECTURE
M: Jonas Bonn <jonas@southpole.se>
W: http://openrisc.net
Expand Down
13 changes: 2 additions & 11 deletions drivers/coresight/of_coresight.c
Original file line number Diff line number Diff line change
Expand Up @@ -52,23 +52,14 @@ of_coresight_get_endpoint_device(struct device_node *endpoint)
endpoint, of_dev_node_match);
}

static struct device_node *of_get_coresight_endpoint(
const struct device_node *parent, struct device_node *prev)
{
struct device_node *node = of_graph_get_next_endpoint(parent, prev);

of_node_put(prev);
return node;
}

static void of_coresight_get_ports(struct device_node *node,
int *nr_inport, int *nr_outport)
{
struct device_node *ep = NULL;
int in = 0, out = 0;

do {
ep = of_get_coresight_endpoint(node, ep);
ep = of_graph_get_next_endpoint(node, ep);
if (!ep)
break;

Expand Down Expand Up @@ -140,7 +131,7 @@ struct coresight_platform_data *of_get_coresight_platform_data(
/* Iterate through each port to discover topology */
do {
/* Get a handle on a port */
ep = of_get_coresight_endpoint(node, ep);
ep = of_graph_get_next_endpoint(node, ep);
if (!ep)
break;

Expand Down
11 changes: 1 addition & 10 deletions drivers/gpu/drm/imx/imx-drm-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -431,15 +431,6 @@ int imx_drm_encoder_parse_of(struct drm_device *drm,
}
EXPORT_SYMBOL_GPL(imx_drm_encoder_parse_of);

static struct device_node *imx_drm_of_get_next_endpoint(
const struct device_node *parent, struct device_node *prev)
{
struct device_node *node = of_graph_get_next_endpoint(parent, prev);

of_node_put(prev);
return node;
}

/*
* @node: device tree node containing encoder input ports
* @encoder: drm_encoder
Expand All @@ -457,7 +448,7 @@ int imx_drm_encoder_get_mux_id(struct device_node *node,
return -EINVAL;

do {
ep = imx_drm_of_get_next_endpoint(node, ep);
ep = of_graph_get_next_endpoint(node, ep);
if (!ep)
break;

Expand Down
15 changes: 4 additions & 11 deletions drivers/gpu/drm/rcar-du/rcar_du_kms.c
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ static int rcar_du_encoders_init_one(struct rcar_du_device *rcdu,
enum rcar_du_encoder_type enc_type = RCAR_DU_ENCODER_NONE;
struct device_node *connector = NULL;
struct device_node *encoder = NULL;
struct device_node *prev = NULL;
struct device_node *ep_node = NULL;
struct device_node *entity_ep_node;
struct device_node *entity;
int ret;
Expand All @@ -225,11 +225,7 @@ static int rcar_du_encoders_init_one(struct rcar_du_device *rcdu,
entity_ep_node = of_parse_phandle(ep->local_node, "remote-endpoint", 0);

while (1) {
struct device_node *ep_node;

ep_node = of_graph_get_next_endpoint(entity, prev);
of_node_put(prev);
prev = ep_node;
ep_node = of_graph_get_next_endpoint(entity, ep_node);

if (!ep_node)
break;
Expand Down Expand Up @@ -300,23 +296,20 @@ static int rcar_du_encoders_init_one(struct rcar_du_device *rcdu,
static int rcar_du_encoders_init(struct rcar_du_device *rcdu)
{
struct device_node *np = rcdu->dev->of_node;
struct device_node *prev = NULL;
struct device_node *ep_node = NULL;
unsigned int num_encoders = 0;

/*
* Iterate over the endpoints and create one encoder for each output
* pipeline.
*/
while (1) {
struct device_node *ep_node;
enum rcar_du_output output;
struct of_endpoint ep;
unsigned int i;
int ret;

ep_node = of_graph_get_next_endpoint(np, prev);
of_node_put(prev);
prev = ep_node;
ep_node = of_graph_get_next_endpoint(np, ep_node);

if (ep_node == NULL)
break;
Expand Down
1 change: 0 additions & 1 deletion drivers/media/platform/am437x/am437x-vpfe.c
Original file line number Diff line number Diff line change
Expand Up @@ -2504,7 +2504,6 @@ vpfe_get_pdata(struct platform_device *pdev)
GFP_KERNEL);
pdata->asd[i]->match_type = V4L2_ASYNC_MATCH_OF;
pdata->asd[i]->match.of.node = rem;
of_node_put(endpoint);
of_node_put(rem);
}

Expand Down
3 changes: 2 additions & 1 deletion drivers/media/platform/soc_camera/soc_camera.c
Original file line number Diff line number Diff line change
Expand Up @@ -1694,14 +1694,15 @@ static void scan_of_host(struct soc_camera_host *ici)
if (!i)
soc_of_bind(ici, epn, ren->parent);

of_node_put(epn);
of_node_put(ren);

if (i) {
dev_err(dev, "multiple subdevices aren't supported yet!\n");
break;
}
}

of_node_put(epn);
}

#else
Expand Down
5 changes: 3 additions & 2 deletions drivers/of/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,7 @@ obj-$(CONFIG_OF_PROMTREE) += pdt.o
obj-$(CONFIG_OF_ADDRESS) += address.o
obj-$(CONFIG_OF_IRQ) += irq.o
obj-$(CONFIG_OF_NET) += of_net.o
obj-$(CONFIG_OF_UNITTEST) += of_unittest.o
of_unittest-objs := unittest.o unittest-data/testcases.dtb.o
obj-$(CONFIG_OF_UNITTEST) += unittest.o
obj-$(CONFIG_OF_MDIO) += of_mdio.o
obj-$(CONFIG_OF_PCI) += of_pci.o
obj-$(CONFIG_OF_PCI_IRQ) += of_pci_irq.o
Expand All @@ -16,5 +15,7 @@ obj-$(CONFIG_OF_RESERVED_MEM) += of_reserved_mem.o
obj-$(CONFIG_OF_RESOLVE) += resolver.o
obj-$(CONFIG_OF_OVERLAY) += overlay.o

obj-$(CONFIG_OF_UNITTEST) += unittest-data/

CFLAGS_fdt.o = -I$(src)/../../scripts/dtc/libfdt
CFLAGS_fdt_address.o = -I$(src)/../../scripts/dtc/libfdt
41 changes: 33 additions & 8 deletions drivers/of/base.c
Original file line number Diff line number Diff line change
Expand Up @@ -2082,14 +2082,45 @@ int of_graph_parse_endpoint(const struct device_node *node,
}
EXPORT_SYMBOL(of_graph_parse_endpoint);

/**
* of_graph_get_port_by_id() - get the port matching a given id
* @parent: pointer to the parent device node
* @id: id of the port
*
* Return: A 'port' node pointer with refcount incremented. The caller
* has to use of_node_put() on it when done.
*/
struct device_node *of_graph_get_port_by_id(struct device_node *parent, u32 id)
{
struct device_node *node, *port;

node = of_get_child_by_name(parent, "ports");
if (node)
parent = node;

for_each_child_of_node(parent, port) {
u32 port_id = 0;

if (of_node_cmp(port->name, "port") != 0)
continue;
of_property_read_u32(port, "reg", &port_id);
if (id == port_id)
break;
}

of_node_put(node);

return port;
}
EXPORT_SYMBOL(of_graph_get_port_by_id);

/**
* of_graph_get_next_endpoint() - get next endpoint node
* @parent: pointer to the parent device node
* @prev: previous endpoint node, or NULL to get first
*
* Return: An 'endpoint' node pointer with refcount incremented. Refcount
* of the passed @prev node is not decremented, the caller have to use
* of_node_put() on it when done.
* of the passed @prev node is decremented.
*/
struct device_node *of_graph_get_next_endpoint(const struct device_node *parent,
struct device_node *prev)
Expand Down Expand Up @@ -2125,12 +2156,6 @@ struct device_node *of_graph_get_next_endpoint(const struct device_node *parent,
if (WARN_ONCE(!port, "%s(): endpoint %s has no parent node\n",
__func__, prev->full_name))
return NULL;

/*
* Avoid dropping prev node refcount to 0 when getting the next
* child below.
*/
of_node_get(prev);
}

while (1) {
Expand Down
2 changes: 2 additions & 0 deletions drivers/of/unittest-data/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
testcases.dtb
testcases.dtb.S
7 changes: 7 additions & 0 deletions drivers/of/unittest-data/Makefile
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
obj-y += testcases.dtb.o

targets += testcases.dtb testcases.dtb.S

.SECONDARY: \
$(obj)/testcases.dtb.S \
$(obj)/testcases.dtb
Loading

0 comments on commit a2166ca

Please sign in to comment.