Closed
Description
The replay test in mcxcl/test/testmcx.sh has not been robust and often fails in Apple or Intel iGPU OpenCL devices.
this is partly because of two bugs
- we dynamically compute replay.tof for each replayed photon when loading from the history file, but the recomputed tof may exceeds cfg.tend slightly because of the accumulated round-off-errors of total tof (
f.t
) in the kernel - when a replayed photon packet exceeds tend, we skip this packet for replay, but the mcx_utils code fails to reset the
cfg->replay.tof[]
value, causing the subsequent photons are also skipping until the very end
this issue also happens in CUDA based mcx, but the precision seems to be slightly better on NVIDIA GPUs, and thus the skipped photon does not happen often.
Metadata
Metadata
Assignees
Labels
No labels