Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of url patterns as it's removed in Django 1.10 #10

Merged
merged 2 commits into from
Mar 31, 2017

Conversation

jacobh
Copy link
Contributor

@jacobh jacobh commented Sep 1, 2016

No description provided.

@nbonnotte
Copy link

Looks great!

@fangli I hope this will be merged soon :)

@fangli
Copy link
Owner

fangli commented Oct 20, 2016

Yes I hope we could move on to 1.10 right now but the fact is many old projects still use django 1.6-1.9, In order to keep backward-compatibility I did a lot to maintain the current code.

I will merge it soon and consider dropping the support for old django versions.

Thanks!

@jacobh
Copy link
Contributor Author

jacobh commented Oct 20, 2016

Django 1.6 (and possibly older versions) supports defining urlpatterns as a list - see http://django.readthedocs.io/en/1.6.x/topics/http/urls.html?highlight=urlpatterns#syntax-of-the-urlpatterns-variable

@FlipperPA
Copy link

FlipperPA commented Nov 15, 2016

Just revisiting this: the only currently supported versions of Django are now 1.8 (LTS), 1.9 and 1.10.

See here: https://www.djangoproject.com/download/#supported-versions

Would it be worth making a branch for Django less than 1.7 and bringing the main branch and PyPI release up to 1.8 / 1.10 compatibility?

@willseward
Copy link

Whoops. I made a PR for this without looking first.

#15

@fangli fangli merged commit 6fd0283 into fangli:master Mar 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants