-
Notifications
You must be signed in to change notification settings - Fork 11
Made QQube Domain Parameter Names More Meaningful #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice. I think we should also renome the other domain parameters for consistency
# Conflicts: # Pyrado/pyrado/environments/mujoco/assets/furuta_pendulum.xml # Pyrado/pyrado/environments/mujoco/quanser_qube.py # Pyrado/tests/algorithms/test_meta.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please wait with merging
@fdamken I am nor ready to merge this PR after it has been rebased |
# Conflicts: # Pyrado/pyrado/environments/pysim/pandavis.py # Pyrado/pyrado/policies/special/environment_specific.py # Pyrado/scripts/training/qq-su_npdr.py
Renamed * g * Rm * km * Mr * Lr * Dr * Mp * Lp * Dp to the corresponding new names.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I forgot to tell you that the matlab files should not be changed
Depends on #74.