Skip to content

Made QQube Domain Parameter Names More Meaningful #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Jun 28, 2021

Conversation

fdamken
Copy link
Collaborator

@fdamken fdamken commented Jun 21, 2021

Depends on #74.

@fdamken fdamken requested a review from famura June 21, 2021 10:17
@famura famura self-assigned this Jun 21, 2021
@famura famura added the enhancement New feature or request label Jun 21, 2021
Copy link
Owner

@famura famura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. I think we should also renome the other domain parameters for consistency

fdamken added 5 commits June 22, 2021 15:48
# Conflicts:
#	Pyrado/pyrado/environments/mujoco/assets/furuta_pendulum.xml
#	Pyrado/pyrado/environments/mujoco/quanser_qube.py
#	Pyrado/tests/algorithms/test_meta.py
@fdamken fdamken requested a review from famura June 22, 2021 15:29
Copy link
Owner

@famura famura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wait with merging

@famura
Copy link
Owner

famura commented Jun 27, 2021

@fdamken I am nor ready to merge this PR after it has been rebased

fdamken added 2 commits June 28, 2021 13:49
# Conflicts:
#	Pyrado/pyrado/environments/pysim/pandavis.py
#	Pyrado/pyrado/policies/special/environment_specific.py
#	Pyrado/scripts/training/qq-su_npdr.py
Renamed
* g
* Rm
* km
* Mr
* Lr
* Dr
* Mp
* Lp
* Dp
to the corresponding new names.
@fdamken fdamken requested a review from famura June 28, 2021 12:58
Copy link
Owner

@famura famura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I forgot to tell you that the matlab files should not be changed

@fdamken fdamken requested a review from famura June 28, 2021 13:22
@famura famura merged commit ab84d84 into famura:master Jun 28, 2021
famura added a commit that referenced this pull request Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants