Repository navigation
Conversation
|
@mgrabina is attempting to deploy a commit to the Aave Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avatar calls normalize(ensName ?? '') during render. If the connected wallet's reverse-resolved primary ENS name contains disallowed characters (real example: the zalgo-text name on 0xfb3c7eb936cAA12B5A884d612393969A557d4307), normalize throws and the consuming app's whole React tree unmounts with a white screen.
This guards the call and falls back to '', matching the existing behavior when no name resolves: the avatar query stays disabled and the fallback avatar renders. The raw name still displays.
Hit this in production on app.aave.com; we are shipping it as a patch-package patch in the meantime (aave/interface#3076).
Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.