MSC3911 AP5: Updating the room creation handler to recognize attaching media when restricted #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason-famedly
force-pushed
the
jason/msc3911-ap3-sending-events
branch
from
6d8d0e8 to
5529009
Compare
jason-famedly
force-pushed
the
jason/msc3911-ap5-room-creation
branch
from
525bda8 to
a713f08
Compare
nico-famedly
reviewed
Sep 3, 2025
nico-famedly
reviewed
Sep 3, 2025
nico-famedly
reviewed
Sep 3, 2025
jason-famedly
force-pushed
the
jason/msc3911-ap5-room-creation
branch
from
a713f08 to
1476589
Compare
nico-famedly
reviewed
Sep 4, 2025
nico-famedly
reviewed
Sep 4, 2025
jason-famedly
commented
Sep 4, 2025
jason-famedly
force-pushed
the
jason/msc3911-ap5-room-creation
branch
2 times, most recently
from
42a5d57 to
eebfb67
Compare
Contributor
Author
|
I'm not sure I like where this ended up living in the code base. Is there a better place? |
nico-famedly
reviewed
Sep 5, 2025
nico-famedly
approved these changes
Sep 5, 2025
…tach restricted m.room.avatar media
jason-famedly
force-pushed
the
jason/msc3911-ap5-room-creation
branch
from
eebfb67 to
c9aee37
Compare
Contributor
Author
|
Complement test failures are because the base branch does not have a current version of Synapse merged in yet. The sytest failure for Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Media MSC3911 AP5: Updating the room creation endpoints to allow attaching media
For https://github.com/famedly/product-management/issues/3355
Out-of-band discussion realized that passing a query argument to the room creation endpoint would be pointless, as:
m.room.avatarevent, it would do nothing appropriate(accepting room creator membership event, which should be part of the copy media system for automatic handling)m.room.avatarevent, then that is all we need to discover the media id