MSC3911 AP3: Update methods for sending events to allow attaching media #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason-famedly
commented
Aug 26, 2025
Member
nico-famedly
left a comment
nico-famedly
left a comment
There was a problem hiding this comment.
Looks good in general, but I think we need to figure out the multiple events case as well as the potential persistence race.
itsoyou
reviewed
Aug 26, 2025
itsoyou
reviewed
Aug 26, 2025
jason-famedly
commented
Aug 28, 2025
nico-famedly
approved these changes
Aug 28, 2025
Member
nico-famedly
left a comment
nico-famedly
left a comment
There was a problem hiding this comment.
Looks good to me in general, but could use some minor cleanups :)
jason-famedly
force-pushed
the
jason/msc3911-ap3-sending-events
branch
2 times, most recently
from
cd18754 to
a80fe44
Compare
Contributor
Author
|
Had a As such, it has been reverted |
jason-famedly
force-pushed
the
jason/msc3911-ap3-sending-events
branch
4 times, most recently
from
b33bbda to
227e429
Compare
nico-famedly
reviewed
Sep 3, 2025
jason-famedly
force-pushed
the
jason/msc3911-ap3-sending-events
branch
from
6d8d0e8 to
5529009
Compare
nico-famedly
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/famedly/product-management/issues/3353
Allow two endpoints:
PUT /_matrix/client/v3/rooms/{roomId}/state/{eventType}/{stateKey}PUT /_matrix/client/v3/rooms/{roomId}/send/{eventType}/{txnId}To have query parameter
org.matrix.msc3911.attach_media(attach_mediaonce stabilized) that accepts a list ofmxcurls(both with and without themxc://scheme)The
mxcreferences should have been uploaded previously.By passing these
mxcreferences to these endpoints, an association between the event being created and the piece(s) of media will be formed. Restricting the media to be viewable based on event visibility criteria is a future work.