fix(MSC3911): Handle profile avatars that are unknown gracefully #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason-famedly
force-pushed
the
jason/remote-media-profiles
branch
from
09bf11f to
fc1eaab
Compare
jason-famedly
commented
Oct 22, 2025
jason-famedly
force-pushed
the
jason/remote-media-profiles
branch
from
59caf7d to
815ff8f
Compare
itsoyou
reviewed
Oct 23, 2025
jason-famedly
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: famedly/product-management#3448
Be more selective about what avatar url's are allowed to be set to the profile of a given user. Particularly around remote media, but any media that is suddenly "missing" could have this error.
Enhance the pre-flight validation to ensure that the media exists, with selective conditions during the transition away from unrestricted media to either ignore the error or forbid the operation.
Gracefully handle updating membership events during a profile avatar change propagation. Most of the potential errors that can be raised here should now be blocked by the pre-flight validation when setting the profile. Additionally, outgoing remote invites and room creator join membership events conditionally drop the avatar url if the media does not exist and legacy unrestricted media is disabled