Skip to content

Conversation

@mzaniolo
Copy link
Contributor

@mzaniolo mzaniolo commented Feb 6, 2025

Closes: #46

This implementation is not caching the jwks. If we expect many request to be validated we should add a cache to it.

@mzaniolo mzaniolo requested a review from a team as a code owner February 6, 2025 16:42
@mzaniolo mzaniolo force-pushed the mzaniolo/fetch_jwks branch from de92c41 to fa1f012 Compare February 7, 2025 07:38
@codecov
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 95.83333% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.90%. Comparing base (2fca463) to head (fa1f012).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
synapse_token_authenticator/config.py 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #47      +/-   ##
==========================================
+ Coverage   80.63%   80.90%   +0.26%     
==========================================
  Files          17       17              
  Lines        1420     1440      +20     
  Branches      158      160       +2     
==========================================
+ Hits         1145     1165      +20     
+ Misses        204      203       -1     
- Partials       71       72       +1     
Files with missing lines Coverage Δ
synapse_token_authenticator/token_authenticator.py 71.87% <100.00%> (+0.44%) ⬆️
tests/__init__.py 86.48% <100.00%> (ø)
tests/test_oauth.py 100.00% <100.00%> (ø)
synapse_token_authenticator/config.py 66.21% <50.00%> (+0.46%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fca463...fa1f012. Read the comment docs.

@mzaniolo mzaniolo mentioned this pull request Feb 10, 2025
@mzaniolo mzaniolo merged commit fa1f012 into main Feb 10, 2025
6 checks passed
@mzaniolo mzaniolo deleted the mzaniolo/fetch_jwks branch February 10, 2025 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add jwks url

4 participants