fix: Replies in threads #2179
Open
fix: Replies in threads #2179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2179 +/- ##
==========================================
+ Coverage 57.05% 57.07% +0.01%
==========================================
Files 151 151
Lines 19280 19279 -1
==========================================
+ Hits 11001 11003 +2
+ Misses 8279 8276 -3
Continue to review full report in Codecov by Sentry.
|
td-famedly
requested changes
Nov 5, 2025
Member
td-famedly
left a comment
td-famedly
left a comment
There was a problem hiding this comment.
shouldn't your is_falling_back be true then? that would mean the same functionality afaik?
td-famedly
reviewed
Nov 5, 2025
krille-chan
force-pushed
the
krille/fix-replies-in-threads
branch
from
3feab44 to
367c856
Compare
and Event.relationshipEventId with Event.inReplyToEventId() for replies. This fixes the situation that an event can be a reply and in a thread. Before we have seen reply as an relationshipType but this does conflict with the concept of threads, where an event can be of relationship type "thread" but also be a reply with being a fallback or not.
krille-chan
force-pushed
the
krille/fix-replies-in-threads
branch
from
367c856 to
b275785
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the situation that an event can be
a reply and in a thread. Before we have seen reply
as an relationshipType but this does conflict with
the concept of threads, where an event can be
of relationship type "thread" but also be a reply
with being a fallback or not.
Some thoughts:
We have
Event.getReplyEvent()andEvent.relationshipType. And there are three different cases:is_falling_back = true)is_falling_back = false)Expected return for
Event.relationshipType:RelationshipType.replyRelationshipType.threadRelationshipType.replyand replace it with aEvent.isReplyWe should remove the
RelationshipType.replywhich is actually not a relationshiptype according to the matrix spec. Instead we should add a new getterEvent.inReplyToEventId({bool includingFallback = true})where we can also say if we want to include fallbacks or not.