Skip to content

Commit

Permalink
Set AssemblyName to FaluSdk and PackageId to Falu (#250)
Browse files Browse the repository at this point in the history
`falu-cli` generates an assembly/executable named `falu` hence why the
output for this project should be `FaluSdk`. Before #244, this was the
output.
  • Loading branch information
mburumaxwell authored Jul 1, 2024
1 parent 0ac52f6 commit db82384
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 4 deletions.
8 changes: 4 additions & 4 deletions falu-dotnet.sln
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,17 @@ Microsoft Visual Studio Solution File, Format Version 12.00
# Visual Studio Version 17
VisualStudioVersion = 17.0.31919.166
MinimumVisualStudioVersion = 10.0.40219.1
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Falu", "src\Falu\Falu.csproj", "{963DEBFA-CB4D-4A2F-8AE4-5C64D6917730}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Falu.Tests", "tests\Falu.Tests\Falu.Tests.csproj", "{BC55832D-F48D-41CC-80A5-B4C36C289C3F}"
EndProject
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "src", "src", "{C024C82C-F934-46C4-A477-09B3890B6127}"
ProjectSection(SolutionItems) = preProject
src\Directory.Build.props = src\Directory.Build.props
EndProjectSection
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Falu", "src\Falu\Falu.csproj", "{963DEBFA-CB4D-4A2F-8AE4-5C64D6917730}"
EndProject
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "tests", "tests", "{F29660E1-F3A8-4EB9-A189-B26053912E98}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Falu.Tests", "tests\Falu.Tests\Falu.Tests.csproj", "{BC55832D-F48D-41CC-80A5-B4C36C289C3F}"
EndProject
Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
Debug|Any CPU = Debug|Any CPU
Expand Down
10 changes: 10 additions & 0 deletions src/Falu/Falu.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,16 @@
<PackageIcon>falu-logo.png</PackageIcon>
</PropertyGroup>

<PropertyGroup>
<!--
The project is named Falu but produces and assembly named FaluSdk and not Falu because it is used
in the CLI which produces an assembly/executable also named Falu hence causes collisions and build failure.
Instead of renaming the whole project, we set the AssemblyName and PackageId to what we want.
-->
<AssemblyName>FaluSdk</AssemblyName>
<PackageId>Falu</PackageId>
</PropertyGroup>

<ItemGroup>
<InternalsVisibleTo Include="Falu.Tests" />
</ItemGroup>
Expand Down

0 comments on commit db82384

Please sign in to comment.